Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce github api calls in hashtable syncing from 2 to 1 #215

Closed
wants to merge 1 commit into from

Conversation

Morilli
Copy link
Collaborator

@Morilli Morilli commented Aug 4, 2023

By default, Octokit only gets 60 api calls per hour, which is pretty low, especially considering Obsidian can do up to 3 api calls on startup (2 for hashtable syncing, 1 for self update check). I have hit this myself when doing testing and could imagine other people hitting it, so here's a free optimization that merges both hashtable api calls into one.

Not entirely happy with this being a class field but this is all only called once anyway, so I don't think doing anything advanced is necessary here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant